In U.S law impeachment is the same as filing a criminal charge against someone. In this case specifically a charge of misconduct against a holder of public office. A number of people mistakenly think that to say someone was impeached is the outcome. However, just as in a jury trial, the public office holder must be found guilty of the alleged offense. Clinton was impeached by the U.S. House of Representatives, but was not found guilty by the trial body--i.e., the U.S. Senate. Same outcome with Andrew Johnson, the only other President impeached.
So there will always be a political issue in any impeachment of the sitting President. For instance, the Senate was majority Democrat when Clinton was impeached and acquitted. Unless, Trump were to be found guilty of treason or something else serious--murder, perhaps--it is unlikely that a Republican majority in the U.S. Senate would not acquit him.
